feat: add Back to Home button in Vector Studio header#183
feat: add Back to Home button in Vector Studio header#183Tirthpanchori wants to merge 2 commits into
Conversation
|
@Tirthpanchori is attempting to deploy a commit to the winter262005's projects Team on Vercel. A member of the Team first needs to authorize it. |
Ishwarpatra
left a comment
There was a problem hiding this comment.
hey,few issues here,
-
Hardcoded Path Fragility
- The link uses
../../index.htmlwhich assumes a fixed directory structure - my recommendation is ro Consider making this more robust by:
- Adding a comment documenting the expected structure
- Or using a JavaScript approach to set the path dynamically based on the current location
- The link uses
-
HTML Semantics & Accessibility
- The button is implemented as an
<a>tag styled as a button, but screen readers may announce it differently than expected
hint:-<a href="../../index.html" class="back-home-btn" aria-label="Return to home">HOME</a>
- Add
aria-labelto improve screen reader experience
- The button is implemented as an
-
Styling Duplication is not appreicated
.back-home-btnand.btnshare nearly identical styles (padding, font, border, cursor, hover effects)- you need to Refactor to reduce duplication:
.btn, .back-home-btn { /* shared styles */ } .back-home-btn:hover { border-color: var(--accent); color: var(--accent); }
-
Mobile Responsiveness would be a issue
- Consider testing on narrow viewports to ensure the button doesn't cause layout shifts
- The fixed styling looks good but responsive testing would be valuable
-
Also Navigation Path Validation
- Verify that
index.htmlexists and is accessible from all deployment contexts (local dev, production, etc.)
take time ,don't rush it
ok, i'll work on it |
Hi! I've addressed all the review points:
Regarding mobile responsiveness — I tested on iPhone 14 viewport (393x852) in DevTools and noticed the overall header layout already has pre-existing overflow issues on mobile (VECTOR STUDIO text wrapping, export buttons clipping off-screen, properties panel overlapping the canvas). Fixing the back-home-btn alone in isolation wouldn't meaningfully improve the mobile experience since the root cause is the header's layout at narrow viewports. I'd suggest this be tracked as a separate issue so it gets a proper responsive overhaul. |

Summary
Added a "HOME" navigation button to the top-left of the Vector Studio header so users can return to the main dashboard without using browser history.
Related Issue
Closes #161
Changes
<a>anchor tag with classback-home-btnin the header, placed before the polyline icon and "Vector Studio" title.back-home-btnCSS using existing CSS variables (var(--text),var(--border),var(--accent)) so it automatically adapts to both dark and light mode../../index.htmlwhich correctly resolves to the root index fromtools/vector-studio/Testing
Testing Steps
tools/vector-studio/vector_studio.htmlin browserindex.html(the main homepage)Contributor Details
Checklist before requesting a review
.envvalues are committed