Skip to content

Fixing packet fields bugs #2511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaytecat wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fixing packet fields bugs #2511

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
506d30c
Fixing packet fields bugs
kaytecat Dec 21, 2025
832462e
Fixed typo on incoming 0x0BF addition
kaytecat Dec 21, 2025
70845f6
Updating label naming and adding alias
kaytecat Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions addons/libs/packets/fields.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,11 +670,11 @@ fields.outgoing[0x05A] = L{
-- Dialogue options
fields.outgoing[0x05B] = L{
{ctype='unsigned int', label='Target', fn=id}, -- 04
{ctype='unsigned short', label='Option Index'}, -- 08
{ctype='unsigned short', label='_unknown1'}, -- 0A
{ctype='unsigned int', label='Option Index'}, -- 08
{ctype='unsigned short', label='Target Index', fn=index}, -- 0C
{ctype='bool', label='Automated Message'}, -- 0E 1 if the response packet is automatically generated, 0 if it was selected by you
{ctype='unsigned char', label='_unknown2'}, -- 0F
{ctype='bool', label='Continue', -- 0E Determines which mode the menu uses
alias='Automated Message'},
{ctype='unsigned char', label='_padding' const=0}, -- 0F
{ctype='unsigned short', label='Zone', fn=zone}, -- 10
{ctype='unsigned short', label='Menu ID'}, -- 12
}
Expand All @@ -685,11 +685,11 @@ fields.outgoing[0x05C] = L{
{ctype='float', label='Z'}, -- 08
{ctype='float', label='Y'}, -- 0C
{ctype='unsigned int', label='Target ID', fn=id}, -- 10 NPC that you are requesting a warp from
{ctype='unsigned int', label='_unknown1'}, -- 14 01 00 00 00 observed
{ctype='unsigned int', label='Option Index'}, -- 14
{ctype='unsigned short', label='Zone'}, -- 18
{ctype='unsigned short', label='Menu ID'}, -- 1A
{ctype='unsigned short', label='Target Index', fn=index}, -- 1C
{ctype='unsigned char', label='_unknown2', const=1}, -- 1E
{ctype='bool', label='Continue', const=true}, -- 1E Always set for warp requests
{ctype='unsigned char', label='Rotation'}, -- 1F
}

Expand Down Expand Up @@ -2030,7 +2030,7 @@ fields.incoming[0x033] = L{
{ctype='char[16]', label='_dupeNPC Name1'}, -- 20
{ctype='char[16]', label='_dupeNPC Name2'}, -- 30
{ctype='char[16]', label='_dupeNPC Name3'}, -- 40
{ctype='char[32]', label='Menu Parameters'}, -- 50 The way this information is interpreted varies by menu.
{ctype='data[32]', label='Menu Parameters'}, -- 50 The way this information is interpreted varies by menu.
}

-- NPC Interaction Type 2
Expand Down Expand Up @@ -3437,7 +3437,7 @@ fields.incoming[0x0AC] = L{
}

fields.incoming[0x0AE] = L{
{ctype='data[7]', label='Mounts'}, -- 04
{ctype='data[7]', label='Mounts'}, -- 04
}

-- Moblin Maze Mongers information
Expand All @@ -3457,6 +3457,14 @@ fields.incoming[0x0B5] = L{
{ctype='unsigned int', label='_unknown2'}, -- 1C
}

-- Reservation Response
fields.incoming[0x0BF] = L{
{ctype='unsigned short', label='_unknown1'}, -- 04
{ctype='unsigned short', label='Result'}, -- 06 Success is 4, other values are failures
{ctype='unsigned int', label='_unknown2'}, -- 08
{ctype='unsigned int', label='NPC Index'}, -- 0C
}

-- Alliance status update
fields.incoming[0x0C8] = L{
{ctype='unsigned char', label='_unknown1'}, -- 04
Expand Down