Include request for refresh token with APIKEY auth#8
Open
creeble wants to merge 1 commit intoWildApricot:masterfrom
Open
Include request for refresh token with APIKEY auth#8creeble wants to merge 1 commit intoWildApricot:masterfrom
creeble wants to merge 1 commit intoWildApricot:masterfrom
Conversation
Include request to generate a refresh token using APIKEY authentication. Without this, the code is fundamentally broken: Calls to _refresh_auth_token() will always fail. Also, this code is fundamentally broken for python3; python2 is officially deprecated. Oof.
Contributor
|
Can confirm that this change made the library work; I spent way too long troubleshooting only to realize @creeble had already fixed the issue. Should always look in the PRs first I guess. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include request to generate a refresh token using APIKEY authentication.
Without this, the code is fundamentally broken: Calls to _refresh_auth_token() will always fail.
Also, this code is fundamentally broken for python3; python2 is officially deprecated. Oof.