fix: show turn phase indicator on mobile + fix tsc errors#6
Open
WiktorStarczewski wants to merge 6 commits intomainfrom
Open
fix: show turn phase indicator on mobile + fix tsc errors#6WiktorStarczewski wants to merge 6 commits intomainfrom
WiktorStarczewski wants to merge 6 commits intomainfrom
Conversation
- Clamp death animation on last frame using LoopOnce so the model stays collapsed instead of looping - Show KO'd champions in death pose during settle/second anim phases and outside animation phase when no survivors remain - Track secondActed in AnimScript to avoid playing attack animation for champions KO'd before their turn
Port TypeScript combat engine to #![no_std] Rust in crates/combat-engine/. Zero dependencies, fixed-point arithmetic, no heap allocation. Modules: types, elements, champions, damage, codec, combat. 33 tests including full 3v3 battle integration test.
- Install cargo-miden v0.7.1, scaffold account + program templates - Import combat-engine crate into Miden program, compile to .masp - Execute 1v1 combat in Miden VM: output matches native Rust exactly - Add resolve_turn_mut to combat-engine (Miden-friendly in-place variant) - Discovered compiler bug: large struct returns silently miscompiled - Workaround: inline combat logic instead of returning TurnResult - Track findings in tasks/todo.md and tasks/lessons.md
- Arena account component (contracts/arena-account/) with 21-slot storage layout - 6 procedures: join, set_team, submit_commit, submit_reveal, resolve_current_turn, claim_timeout - Inlined combat resolution (all ability types, burn, buffs, team elimination) - Champion state packing module (crates/combat-engine/src/pack.rs) with 7 native tests - Compiler bug repro (contracts/combat-test-broken/) for Dennis - SHA-256 verification, P2ID payouts, and block height access deferred as TODOs - Builds to 381KB .masp, all 40 combat-engine tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hidden sm:blocksrc/vite-env.d.tsto resolve allimport.meta.envTypeScript errorsTest plan
npx tsc --noEmitpasses with zero errors