WIK-2147: Group log archives by year subdirectory#12
Open
Conversation
- New archives go under CRON_LOG_DIR/YYYY/ (e.g. 2025/01-01_task.tar.gz). - find_newest_archive now searches both flat dir and year subdirs. - When newest archive is in a year subdir, previous_period is derived from year-basename. - README: document directory layout and backward compatibility. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🐳 The image based on 4cdbbaf4 commit has been built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIK-2147: Update cron image logs archival script directory structure
Archives are now stored in year subdirectories as requested:
2025-01-01.taskname.tar.gz,2025-01-02.taskname.tar.gz(flat)2025/01-01.taskname.tar.gz,2025/01-02.taskname.tar.gzChanges
CRON_LOG_DIR/YYYY/, and write the archive asYYYY/rest.tar.gz. When reading the newest existing archive, deriveprevious_periodfrom path (year + basename) when the archive lives in a year subdir.find_newest_archivenow searches both the flat directory (*.tar.gz) and year subdirs (*/*.tar.gz), so existing flat archives and new year-subdir archives are both considered when determining the newest.Backward compatible: existing flat archives remain valid; new runs create only year-subdir archives.
Made with Cursor