Conversation
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
5219581 to
5fa65f6
Compare
5fa65f6 to
9178973
Compare
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
purpshell
left a comment
There was a problem hiding this comment.
Alternatively, we can do some sort of libsignal.withLogger approach and import from that or something, I'm not sure. Well since the socket itself is taking in the logger, it becomes hard to pull something like .withLogger at the top of the code.
Since this is still a draft, please think of alternate ways of adding the logger without modifying function signatures. Maybe Curve.withLogger().verify. And the withLogger returns this after the logger has been added, and without the logger there is maybe a default logger or nothing. This way no breaking change is made.
bd1c658 to
f46e8b1
Compare
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
aside: WhiskeySockets/libsignal-node#12