Skip to content

[NET-289] - MCC naming minus the hyphen #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pollaro merged 2 commits into from
Sep 3, 2025
Merged

[NET-289] - MCC naming minus the hyphen #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56a5abc
remove hyphen from calling file
pollaro Aug 15, 2025
7a90402
make consistent code
pollaro Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions +nla/+net/+result/+plot/NetworkTestPlot.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,7 @@ function drawFigure(obj, plot_type)
end
obj.getPlotTitle();

switch obj.current_settings.mcc
case "Benjamini-Hochberg"
mcc = "BenjaminiHochberg";
case "Benjamini-Yekutieli"
mcc = "BenjaminiYekutieli";
otherwise
mcc = obj.current_settings.mcc;
end
mcc = obj.current_settings.(erase(mcc, "-"));

probability = NetworkTestResult().getPValueNames(obj.test_method, obj.network_test_result.test_name);

Expand Down
2 changes: 1 addition & 1 deletion +nla/+net/+result/NetworkResultPlotParameter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@

% Get the scale max and the labels
if isstring(fdr_correction) || ischar(fdr_correction)
fdr_correction = nla.net.mcc.(fdr_correction)();
fdr_correction = nla.net.mcc.(erase(fdr_correction, "-"))();
end
p_value_max = fdr_correction.correct(obj.network_atlas, obj.updated_test_options, statistic_input);
p_value_breakdown_label = fdr_correction.createLabel(obj.network_atlas, obj.updated_test_options,...
Expand Down
Loading