Skip to content

[NET-278] Fix for Hypergeometric Test Winkler and Westfall-Young rankings #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pollaro merged 1 commit into from
Jun 3, 2025
Merged

[NET-278] Fix for Hypergeometric Test Winkler and Westfall-Young rankings #118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions +nla/+net/ResultRank.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,12 @@
% :return: The same NetworkTestResult object with ranking results

winkler_probability = strcat("winkler_", probability);
% NET-278: The "max statistic" for hypergeometric is the most significant p-value. Which is the smallest p-value.
max_statistic_array = max(abs(permutation_results.(strcat(ranking_statistic, "_permutations")).v));
if isequal(ranking.test_name, "hypergeometric")
max_statistic_array = min(abs(permutation_results.(strcat(ranking_statistic, "_permutations")).v));
end

for index = 1:numel(no_permutation_results.(strcat("uncorrected_", probability)).v)
if isequal(ranking.test_name, "hypergeometric")
ranking.(test_method).(winkler_probability).v(index) = sum(...
Expand Down Expand Up @@ -153,14 +158,20 @@
max_per_permutation_reducing_rows = zeros(...
size(permutations_sorted_by_non_permuted, 1), size(permutations_sorted_by_non_permuted, 2)...
);
for row_index = size(permutations_sorted_by_non_permuted, 1):-1:2
max_per_permutation_reducing_rows(row_index, :) = max(permutations_sorted_by_non_permuted(1:row_index, :));
end
max_per_permutation_reducing_rows(1, :) = permutations_sorted_by_non_permuted(1, :);

if isequal(ranking.test_name, "hypergeometric")
% NET-278: The "max statistic" for hypergeometric is the most significant p-value. Which is the smallest p-value.
for row_index = size(permutations_sorted_by_non_permuted, 1):-1:2
max_per_permutation_reducing_rows(row_index, :) = min(permutations_sorted_by_non_permuted(1:row_index, :));
end
max_per_permutation_reducing_rows(1, :) = permutations_sorted_by_non_permuted(1, :);

ranking.(test_method).(westfall_young_probability).v = mean(sorted_no_permutation_results > max_per_permutation_reducing_rows, 2);
else
for row_index = size(permutations_sorted_by_non_permuted, 1):-1:2
max_per_permutation_reducing_rows(row_index, :) = max(permutations_sorted_by_non_permuted(1:row_index, :));
end
max_per_permutation_reducing_rows(1, :) = permutations_sorted_by_non_permuted(1, :);

ranking.(test_method).(westfall_young_probability).v = mean(sorted_no_permutation_results < max_per_permutation_reducing_rows, 2);
end

Expand Down
Loading