-
Notifications
You must be signed in to change notification settings - Fork 20
Feature/circular bct #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feature/circular bct #902
Conversation
Codecov Report
@@ Coverage Diff @@
## master #902 +/- ##
==========================================
- Coverage 46.28% 30.6% -15.69%
==========================================
Files 57 58 +1
Lines 3874 3905 +31
==========================================
- Hits 1793 1195 -598
- Misses 2081 2710 +629
Continue to review full report at Codecov.
|
|
Since some code changed in the model, please update the unit test as well; at least remove the tests that are no longer relevant. Thanks! |
|
I think there may need some documentation on JavaScript code? |
|
Can't you use npm to install the new library you need? Why do you need to copy and paste it in the project? |
|
Also, there are about 400 lines of JavaScript code in the HTML file, with almost all single letter variable name without a single line of documentation. |
|
circular dendograms are still on my list :) .... but i think this code should be moved to [future work] list? thoughts |
Add radial graph to BCT