Skip to content

Conversation

@Landaluce
Copy link
Contributor

Add radial graph to BCT

@codecov
Copy link

codecov bot commented Jun 8, 2019

Codecov Report

Merging #902 into master will decrease coverage by 15.68%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #902       +/-   ##
==========================================
- Coverage   46.28%   30.6%   -15.69%     
==========================================
  Files          57      58        +1     
  Lines        3874    3905       +31     
==========================================
- Hits         1793    1195      -598     
- Misses       2081    2710      +629
Impacted Files Coverage Δ
lexos/views/phylotree_view.py 0% <0%> (ø)
lexos/models/dendro_model.py 51.42% <0%> (-41.43%) ⬇️
lexos/views/bct_view.py 0% <0%> (ø) ⬆️
lexos/models/bct_model.py 88.7% <20%> (-0.91%) ⬇️
lexos/processors/prepare/cutter.py 14.1% <0%> (-85.9%) ⬇️
lexos/models/content_analysis_model.py 26.35% <0%> (-66.79%) ⬇️
lexos/helpers/general_functions.py 24.39% <0%> (-58.69%) ⬇️
lexos/models/matrix_model.py 43.47% <0%> (-52.18%) ⬇️
lexos/processors/prepare/scrubber.py 12.58% <0%> (-50.36%) ⬇️
lexos/helpers/definitions.py 60.86% <0%> (-39.14%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178de88...ecad58e. Read the comment docs.

@WeiqiNs
Copy link
Member

WeiqiNs commented Jun 12, 2019

Since some code changed in the model, please update the unit test as well; at least remove the tests that are no longer relevant. Thanks!

@czhang03
Copy link
Member

I think there may need some documentation on JavaScript code?

@czhang03
Copy link
Member

Can't you use npm to install the new library you need? Why do you need to copy and paste it in the project?

@czhang03
Copy link
Member

Also, there are about 400 lines of JavaScript code in the HTML file, with almost all single letter variable name without a single line of documentation.
I think we need to clean up these code.

@mleblanc321
Copy link
Contributor

circular dendograms are still on my list :) .... but i think this code should be moved to [future work] list? thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants