[codex] fix Responses SSE content part lifecycle for streaming fallback#2880
Open
jerryan999 wants to merge 1 commit into
Open
[codex] fix Responses SSE content part lifecycle for streaming fallback#2880jerryan999 wants to merge 1 commit into
jerryan999 wants to merge 1 commit into
Conversation
Contributor
|
All contributors have signed the CLA. ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
response.content_part.addedbefore the firstresponse.output_text.deltafor streamed text message itemsresponse.content_part.doneafterresponse.output_text.donewith the final accumulated textRoot Cause
The Responses streaming bridges created
response.output_item.addedand then streamedresponse.output_text.deltadirectly, but never opened or closed the active text content part. Clients that enforce the Responses event model, including Codex CLI, therefore rejected text deltas because no active content part existed.Validation
go test ./internal/pkg/apicompatgo test -tags unit ./internal/service -run 'TestForwardResponses_ForceChatCompletionsRoutesStreamingToChatCompletions$'Fixes #2875