Skip to content

Fixing the writing issue (Again)#62

Open
RennJs wants to merge 28 commits intoWeeb-Devs:mainfrom
RennJs:main
Open

Fixing the writing issue (Again)#62
RennJs wants to merge 28 commits intoWeeb-Devs:mainfrom
RennJs:main

Conversation

@RennJs
Copy link
Contributor

@RennJs RennJs commented Apr 11, 2022

I just found alot of writing issue at your code, hope this pull request helps 🙏

Feel free to accept or decline

module.exports = {
name: '8d',
description: 'Set 8d for player',
description: 'Enable/Disable 8d Filters',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, but why the inconsistent capitalization here? Some description use 'This Type of Capitalization', while others use 'This type of capitalization.'

module.exports = {
name: 'volume',
description: 'Set volume',
description: 'Set The Current Song Volume',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be (regardless of capitalization) "Set the current song's volume"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants