Reads filtration change seq length + RF model update#5
Open
TsabarM wants to merge 363 commits intocontrolled_shufflesfrom
Open
Reads filtration change seq length + RF model update#5TsabarM wants to merge 363 commits intocontrolled_shufflesfrom
TsabarM wants to merge 363 commits intocontrolled_shufflesfrom
Conversation
shacharmo
requested changes
Sep 30, 2020
| module_parameters = [fastq_path, first_phase_output_path, first_phase_logs_path, | ||
| barcode2samplename_path, left_construct, right_construct, | ||
| max_mismatches_allowed, min_sequencing_quality, first_phase_done_path, | ||
| max_mismatches_allowed, min_sequencing_quality, minimal_length_required,first_phase_done_path, |
Member
There was a problem hiding this comment.
Mismatch with the definition in read_filtration/module_wrapper.py.
You define that as a named parameter (starts with --) and pass it here as positional parameter.
Also the order is incorrect/doesn't match, you are passing minimal length as done path.
To summarize, this change is wrong and doesn't work
|
|
||
| def get_hyperparameters_grid(seed): | ||
| # Number of trees in random forest | ||
| n_estimators = [int(x) for x in np.linspace(start=100, stop=2000, num=20)] |
Member
There was a problem hiding this comment.
Set parameters using command arguments, parameters shouldn't be hardcoded.
This remark should be applied to entire file, not just this line
| for i in range(num_of_configurations_to_sample): | ||
| configuration = {} | ||
| for key in hyperparameters_grid: | ||
| configuration[key] = np.random.choice(hyperparameters_grid[key], size=1)[0] |
Member
There was a problem hiding this comment.
It this seeded? Would we get same results every experiment run?
| data.drop(['sample_name', 'label'], axis=1, inplace=True) | ||
| # a matrix of the actual feature values | ||
| X_train = data[train_rows_mask].values | ||
| X_test = data[test_rows_mask].values |
Member
There was a problem hiding this comment.
There is no usage in (modified) code - not X_test and not Y_test
Tool all data rf
Rf parallel
Validation files
…s/IgomeProfiling into change_place_stop_machines
change the place of file AWS stop machines from tools to auxiliaries
fix the script by the new requests
change the path of the wsl tutorial
Order of sort motifs bc
Connect positive motifs to pipeline
Flag num sample build cluster
add new script for summary reads in one csv file
Join samples to groups
The motif samples were by sort_by_num_samples, sort_by_unique_memebers, sort_by_cluster_size now its sort_by_num_samples, sort_by_cluster_size , sort_by_unique_memebers when unique members goes from low to high
changed the order of the samples
fixed bug of biological condition type value
Fix unite motifs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.