Skip to content

PolymorphicCallNode should unchain itself first in unlink https://bug… #1665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aoikonomopoulos wants to merge 1 commit into
base: wpe-2.38
Choose a base branch
from
+6 −3
Open

PolymorphicCallNode should unchain itself first in unlink https://bug… #1665

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,16 @@ PolymorphicCallNode::~PolymorphicCallNode()

void PolymorphicCallNode::unlink(VM& vm)
{
// We first remove itself from the linked-list before unlinking m_callLinkInfo.
// The reason is that m_callLinkInfo can potentially link PolymorphicCallNode's stub itself, and it may destroy |this| (the other CallLinkInfo
// does not do it since it is not chained in PolymorphicCallStubRoutine).
if (isOnList())
remove();

if (m_callLinkInfo) {
dataLogLnIf(Options::dumpDisassembly(), "Unlinking polymorphic call at ", m_callLinkInfo->doneLocation(), ", bc#", m_callLinkInfo->codeOrigin().bytecodeIndex());
m_callLinkInfo->unlink(vm);
}

if (isOnList())
remove();
}

void PolymorphicCallNode::clearCallLinkInfo()
Expand Down