-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[Win] Enable AVIF image support #17640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
EWS run on previous version of this PR (hash 45e64ff) Details |
|
waiting WebKitForWindows/WebKitRequirements#168 to be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing stopping anyone who builds the Windows port from adding more libraries into WebKitLibraries/win so if someone wants to do AVIF support they can just add the libraries in there.
I'm fine with making the port more customizable by users like Playwright.
45e64ff to
aed88eb
Compare
|
EWS run on previous version of this PR (hash aed88eb) Details |
https://bugs.webkit.org/show_bug.cgi?id=261368 Reviewed by NOBODY (OOPS!). Enabled USE_AVIF, and unskipped AVIF tests. * LayoutTests/platform/win/TestExpectations: * Source/cmake/OptionsWin.cmake:
aed88eb to
ac62c1c
Compare
|
EWS run on current version of this PR (hash ac62c1c) Details |
donny-dont
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s important to give users the option to not enable things.
Blocked by #36366
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ac62c1c
ac62c1c