Skip to content

Conversation

@fujii fujii self-assigned this Sep 11, 2023
@fujii fujii added the Images For bugs in image handling. label Sep 11, 2023
@fujii fujii marked this pull request as draft September 11, 2023 03:53
@fujii
Copy link
Contributor Author

fujii commented Sep 11, 2023

waiting WebKitForWindows/WebKitRequirements#168 to be merged.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 11, 2023
Copy link
Contributor

@donny-dont donny-dont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's nothing stopping anyone who builds the Windows port from adding more libraries into WebKitLibraries/win so if someone wants to do AVIF support they can just add the libraries in there.

I'm fine with making the port more customizable by users like Playwright.

@fujii fujii removed the merging-blocked Applied to prevent a change from being merged label Apr 18, 2025
@fujii fujii changed the title [Win] AVIF image support [Win] Enable AVIF image support Apr 18, 2025
@fujii fujii force-pushed the eng/win-avif-support branch from 45e64ff to aed88eb Compare April 18, 2025 22:15
@fujii fujii marked this pull request as ready for review April 18, 2025 22:18
@fujii fujii requested review from donny-dont, rkirsling and tats-u and removed request for tats-u April 18, 2025 22:18
https://bugs.webkit.org/show_bug.cgi?id=261368

Reviewed by NOBODY (OOPS!).

Enabled USE_AVIF, and unskipped AVIF tests.

* LayoutTests/platform/win/TestExpectations:
* Source/cmake/OptionsWin.cmake:
@fujii fujii force-pushed the eng/win-avif-support branch from aed88eb to ac62c1c Compare April 18, 2025 22:20
Copy link
Contributor

@donny-dont donny-dont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s important to give users the option to not enable things.

Blocked by #36366

Copy link

@tats-u tats-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have to change any more.
This PR just changes the default value from opt-in to opt-out.
Even if it is blocked by #36366, the fact that we should change the default behavior from opt-in to opt-out won't be changed.
We have only to defer the merge until #36366 is merged.

@fujii fujii closed this Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Images For bugs in image handling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants