fix: correct operator precedence in stepRunnerType resolution#551
Open
MatrixNeoKozak wants to merge 1 commit into
Open
fix: correct operator precedence in stepRunnerType resolution#551MatrixNeoKozak wants to merge 1 commit into
MatrixNeoKozak wants to merge 1 commit into
Conversation
✅ Deploy Preview for webkit-speedometer-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stepRunnerType resolution in SuiteRunner._runSuite incorrectly evaluated this.#suite.type due to operator precedence when this.#suite.type was truthy (e.g., "remote"). Specifically, the ternary operator ? : was incorrectly associated with the ?? operator, leading to scenarios where a specific suite type was overridden by the async/default logic. The expression was refactored to explicitly parenthesize the default logic, ensuring this.#suite.type is correctly prioritized.