Prioritize root project variable for supported android sdk versions#18
Open
mukul-kmr-jha wants to merge 1 commit into
Open
Prioritize root project variable for supported android sdk versions#18mukul-kmr-jha wants to merge 1 commit into
mukul-kmr-jha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, gradle file sets the sdk versions with hardcoded values, giving less control to the project owners controlling the desired sdk versions they are targetting. This fix intends to solve it by checking if these variables are declared in the root project and giving them priority with some fallback version from WE's end.
Prioritize root project variable for supported android sdk versions