Skip to content

merge TCP implementations in tcp.c #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcrichton merged 3 commits into from
Feb 24, 2026
Merged

merge TCP implementations in tcp.c #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e03d87
merge TCP implementations in `tcp.c`
rvolosatovs Feb 24, 2026
4b9e245
address review feedback
rvolosatovs Feb 24, 2026
66395b5
remove sockopt symbols expect
rvolosatovs Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions expected/wasm32-wasip2/defined-symbols.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,6 @@ __wasilibc_rmdirat
__wasilibc_sockaddr_to_wasi
__wasilibc_sockaddr_validate
__wasilibc_stat
__wasilibc_tcp_getsockopt
__wasilibc_tcp_setsockopt
__wasilibc_tell
__wasilibc_unlinkat
__wasilibc_unspecified_addr
Expand Down Expand Up @@ -1346,7 +1344,6 @@ tanl
tcp_borrow_tcp_socket
tcp_create_socket_create_tcp_socket
tcp_create_socket_result_own_tcp_socket_error_code_free
tcp_getpeername
tcp_ip_socket_address_free
tcp_method_tcp_socket_accept
tcp_method_tcp_socket_address_family
Expand Down
2 changes: 0 additions & 2 deletions expected/wasm32-wasip3/defined-symbols.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,6 @@ __wasilibc_rmdirat
__wasilibc_sockaddr_to_wasi
__wasilibc_sockaddr_validate
__wasilibc_stat
__wasilibc_tcp_getsockopt
__wasilibc_tcp_setsockopt
__wasilibc_tell
__wasilibc_unlinkat
__wasilibc_unspecified_addr
Expand Down
4 changes: 1 addition & 3 deletions libc-bottom-half/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ else()
sources/socket.c
sources/sockets_utils.c
sources/sockopt.c
sources/tcp_sockopt.c
sources/tcp.c
)
endif()

Expand All @@ -156,7 +156,6 @@ if(WASI STREQUAL "p2")
sources/wasip2_file.c
sources/wasip2_file_utils.c
sources/wasip2_stdio.c
sources/wasip2_tcp.c
sources/wasip2_udp.c
)
endif()
Expand All @@ -168,7 +167,6 @@ if (WASI STREQUAL "p3")
sources/wasip3_file.c
sources/wasip3_file_utils.c
sources/wasip3_stdio.c
sources/wasip3_tcp.c
sources/wasip3_udp.c
)
endif()
Expand Down
Loading