Skip to content

[test][js-api] WebAssembly.Global.<prototype>.set should not throw without argument#2117

Merged
Ms2ger merged 1 commit intoWebAssembly:mainfrom
Liedtke:cherry_pick_global_set_no_arg
Mar 19, 2026
Merged

[test][js-api] WebAssembly.Global.<prototype>.set should not throw without argument#2117
Ms2ger merged 1 commit intoWebAssembly:mainfrom
Liedtke:cherry_pick_global_set_no_arg

Conversation

@Liedtke
Copy link
Copy Markdown
Contributor

@Liedtke Liedtke commented Mar 16, 2026

This change landed in the Web Platform Tests repository via: web-platform-tests/wpt@5078da5
Corresponding issue: #2075

…hout argument

This change landed in the Web Platform Tests repository via:
web-platform-tests/wpt@5078da5
Corresponding issue: WebAssembly#2075
@Liedtke Liedtke changed the title [test][js-api] WebAssembly.Global.<prototype>set should not throw without argument [test][js-api] WebAssembly.Global.<prototype>.set should not throw without argument Mar 16, 2026
@Liedtke
Copy link
Copy Markdown
Contributor Author

Liedtke commented Mar 16, 2026

It might be worthwhile to note that there are also changes in this repository that aren't available in the WPT file: b238495
(I wasn't aware of this duplication, should I have opened a PR on WPT as well back then?)

@Liedtke
Copy link
Copy Markdown
Contributor Author

Liedtke commented Mar 17, 2026

@eqrion Could you please take a look?

Copy link
Copy Markdown
Collaborator

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Ms2ger Ms2ger merged commit 6a1257e into WebAssembly:main Mar 19, 2026
1 check passed
@Liedtke Liedtke deleted the cherry_pick_global_set_no_arg branch March 19, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants