-
Notifications
You must be signed in to change notification settings - Fork 309
Add detailed tooltips for Sentient items #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Saereth
wants to merge
2
commits into
WayofTime:1.20.1
Choose a base branch
from
Saereth:1.20.1
base: 1.20.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
136 changes: 136 additions & 0 deletions
136
src/main/java/wayoftime/bloodmagic/common/item/soul/SentientTooltipHelper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,136 @@ | ||
| package wayoftime.bloodmagic.common.item.soul; | ||
|
|
||
| import net.minecraft.ChatFormatting; | ||
| import net.minecraft.client.Minecraft; | ||
| import net.minecraft.client.gui.screens.Screen; | ||
| import net.minecraft.network.chat.Component; | ||
| import net.minecraft.world.entity.player.Player; | ||
| import net.minecraftforge.api.distmarker.Dist; | ||
| import net.minecraftforge.api.distmarker.OnlyIn; | ||
| import wayoftime.bloodmagic.api.compat.EnumDemonWillType; | ||
| import wayoftime.bloodmagic.will.PlayerDemonWillHandler; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Locale; | ||
|
|
||
| @OnlyIn(Dist.CLIENT) | ||
| public final class SentientTooltipHelper | ||
| { | ||
| private SentientTooltipHelper() {} | ||
|
|
||
| public static ChatFormatting colorFor(EnumDemonWillType type) | ||
| { | ||
| if (type == null) | ||
| return ChatFormatting.GRAY; | ||
| switch (type) | ||
| { | ||
| case CORROSIVE: | ||
| return ChatFormatting.GREEN; | ||
| case DESTRUCTIVE: | ||
| return ChatFormatting.GOLD; | ||
| case VENGEFUL: | ||
| return ChatFormatting.RED; | ||
| case STEADFAST: | ||
| return ChatFormatting.LIGHT_PURPLE; | ||
| case DEFAULT: | ||
| default: | ||
| return ChatFormatting.DARK_AQUA; | ||
| } | ||
| } | ||
|
|
||
| public static void appendSentientTooltip( | ||
| List<Component> tooltip, | ||
| String flavourKey, | ||
| EnumDemonWillType type, | ||
| int level, | ||
| double bonusDamage, | ||
| Double aoeRadius, | ||
| Double digSpeedBonus, | ||
| int corrosiveWitherTimeTicks, | ||
| int corrosiveWitherAmplifier, | ||
| int steadfastAbsorptionTimeTicks, | ||
| double vengefulMovementSpeed) | ||
| { | ||
| tooltip.add(Component.translatable(flavourKey).withStyle(ChatFormatting.GRAY, ChatFormatting.ITALIC)); | ||
|
|
||
| ChatFormatting color = colorFor(type); | ||
| String typeKey = "tooltip.bloodmagic.currentBaseType." + type.name().toLowerCase(Locale.ROOT); | ||
| Component typeName = Component.translatable(typeKey).withStyle(color); | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.attuned", typeName).withStyle(ChatFormatting.GRAY)); | ||
|
|
||
| if (!Screen.hasShiftDown()) | ||
| { | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.extraInfo").withStyle(ChatFormatting.DARK_GRAY)); | ||
| return; | ||
| } | ||
|
|
||
| Player player = Minecraft.getInstance().player; | ||
| if (level >= 0 && type != EnumDemonWillType.DEFAULT && player != null) | ||
| { | ||
| double pool = PlayerDemonWillHandler.getTotalDemonWill(type, player); | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.levelPool", level + 1, formatNumber(pool)).withStyle(color)); | ||
| } else | ||
| { | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.inactive").withStyle(ChatFormatting.DARK_GRAY)); | ||
| return; | ||
| } | ||
|
|
||
| if (bonusDamage > 0) | ||
| { | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.bonusDamage", formatSigned(bonusDamage)).withStyle(ChatFormatting.GRAY)); | ||
| } | ||
| if (aoeRadius != null) | ||
| { | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.aoe", formatNumber(aoeRadius)).withStyle(ChatFormatting.GRAY)); | ||
| } | ||
|
|
||
| switch (type) | ||
| { | ||
| case CORROSIVE: | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.rider.corrosive", | ||
| formatNumber(corrosiveWitherTimeTicks / 20.0), | ||
| corrosiveWitherAmplifier + 1).withStyle(color)); | ||
| break; | ||
| case STEADFAST: | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.rider.steadfast", | ||
| formatNumber(steadfastAbsorptionTimeTicks / 20.0)).withStyle(color)); | ||
| break; | ||
| case VENGEFUL: | ||
| if (vengefulMovementSpeed > 0) | ||
| { | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.rider.vengeful", | ||
| formatSigned(vengefulMovementSpeed)).withStyle(color)); | ||
| } | ||
| break; | ||
| default: | ||
| break; | ||
| } | ||
| if (digSpeedBonus != null && digSpeedBonus > 0) | ||
| { | ||
| tooltip.add(Component.translatable("tooltip.bloodmagic.sentient.rider.digspeed", formatSigned(digSpeedBonus)).withStyle(ChatFormatting.GRAY)); | ||
| } | ||
| } | ||
|
|
||
| private static String formatNumber(double value) | ||
| { | ||
| if (value == Math.floor(value) && !Double.isInfinite(value)) | ||
| { | ||
| return String.format(Locale.ROOT, "%d", (long) value); | ||
| } | ||
| String s = String.format(Locale.ROOT, "%.2f", value); | ||
| if (s.contains(".")) | ||
| { | ||
| s = s.replaceAll("0+$", ""); | ||
| if (s.endsWith(".")) | ||
| s = s.substring(0, s.length() - 1); | ||
| } | ||
| return s; | ||
| } | ||
|
|
||
| private static String formatSigned(double value) | ||
| { | ||
| String sign = value >= 0 ? "+" : ""; | ||
| return sign + formatNumber(value); | ||
| } | ||
|
|
||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.