Don't copy accessed values in getters. #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamorNiradnug
force-pushed
the
return-reference-in-value
branch
4 times, most recently
from
5f1891a to
2284411
Compare
NamorNiradnug
force-pushed
the
return-reference-in-value
branch
from
2284411 to
61a99b8
Compare
ammen99
approved these changes
Nov 14, 2025
Member
ammen99
left a comment
ammen99
left a comment
There was a problem hiding this comment.
lgtm, thanks!
btw when updating wayfire we should also bump the api/abi version there ..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main concern is the case when
Typeisstd::string. It is a common scenario when copy is unnecessary and for strings it is not too cheap and may cause allocations.P.S. Sorry for the mess with commits and failed builds.