Skip to content

Conversation

@killown
Copy link
Contributor

@killown killown commented Jan 4, 2026

Output:

wayfire --version  
0.11.0-0bdb2e06 (Jan  4 2026) branch master wlroots-0.19.2 [vulkan]

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If at all, I suggest printing the environmental variable for the wlroots renderer (WLR_RENDERER) if set. Printing the version should not require setting up the full wlroots backend+renderer.

@soreau
Copy link
Member

soreau commented Jan 5, 2026

If at all, I suggest printing the environmental variable for the wlroots renderer (WLR_RENDERER) if set. Printing the version should not require setting up the full wlroots backend+renderer.

It seems like this should only be printed in the log, not from --help or --version where the renderer environment variable is not likely to be set.

@ammen99
Copy link
Member

ammen99 commented Jan 5, 2026

If at all, I suggest printing the environmental variable for the wlroots renderer (WLR_RENDERER) if set. Printing the version should not require setting up the full wlroots backend+renderer.

It seems like this should only be printed in the log, not from --help or --version where the renderer environment variable is not likely to be set.

That's also a fair point. I suppose this shouldn't be merged. Thanks nonetheless @killown :)

@ammen99 ammen99 closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants