Skip to content

Conversation

@MattsonCam
Copy link
Member

@MattsonCam MattsonCam commented Apr 10, 2025

Updates the license to BSD 3. For some reason the checks were not successful, so I plan on fixing this in a future pr. Updating the license did not effect the checks here

Updated the license to BSD 3
@d33bs d33bs mentioned this pull request Apr 10, 2025
Copy link
Member

@d33bs d33bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Seems like this is in alignment with the guidance here: https://wayscience.github.io/playbooks/github_strategy.html#2-analysis-repository

On the CI error: you might consider in your pyproject.toml Python constraints something like: >=3.10,<3.12. While I can't explain why Poetry sometimes does this with version patches I've seen it before too and sometimes setting the upper limit to the next minor version can help simplify it enough for Poetry to do the correct thing while abiding roughly the same logic.

@MattsonCam
Copy link
Member Author

LGTM!

Seems like this is in alignment with the guidance here: https://wayscience.github.io/playbooks/github_strategy.html#2-analysis-repository

On the CI error: you might consider in your pyproject.toml Python constraints something like: >=3.10,<3.12. While I can't explain why Poetry sometimes does this with version patches I've seen it before too and sometimes setting the upper limit to the next minor version can help simplify it enough for Poetry to do the correct thing while abiding roughly the same logic.

I'll try that, thanks for the advice!

@MattsonCam MattsonCam mentioned this pull request Apr 10, 2025
@MattsonCam
Copy link
Member Author

Thanks @d33bs, merging now!

@MattsonCam MattsonCam merged commit bd21e56 into main Apr 10, 2025
0 of 2 checks passed
@MattsonCam MattsonCam deleted the update_license branch April 10, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants