adding the API contracts#7
Merged
MikeLippincott merged 11 commits intoWayScience:mainfrom May 7, 2026
Merged
Conversation
d33bs
requested changes
Apr 23, 2026
Member
d33bs
left a comment
There was a problem hiding this comment.
Nice job! I'm requesting changes mainly because I think there's existing tooling you could make use of to reduce the amount of new code you need to create.
If you feel strongly about keeping things as-is just let me know and I'll circle back to give this more thought.
d33bs
approved these changes
May 6, 2026
Member
d33bs
left a comment
There was a problem hiding this comment.
Great work! LGTM, left a few comments about possible improvements.
Co-authored-by: Dave Bunten <ekgto445@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds data contracts for validating inputs and outputs. This is an initial step and will be added to as other modules get added in the future.
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.