add texture#14
Merged
MikeLippincott merged 4 commits intoWayScience:mainfrom May 7, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new texture featurization module based on Haralick features and introduces unit tests covering scaling, per-object extraction, masking, and error handling.
Changes:
- Implement
scale_image()andcompute_texture()usingmahotas.features.haralick. - Add a new test suite for texture featurization (scaling behavior, schema, masking, error-paths).
- Update project dependencies and mark several roadmap items as completed.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
src/zedprofiler/featurization/texture.py |
Implements Haralick-based texture features and grayscale scaling helper |
tests/featurization/test_texture.py |
Adds tests for scaling and texture feature extraction behavior |
pyproject.toml |
Adds new runtime dependencies for the texture implementation |
ROADMAP.md |
Updates roadmap checklist/status for completed modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from typing import Never | ||
|
|
||
| import numpy as np | ||
| from _pytest.monkeypatch import MonkeyPatch |
Comment on lines
+115
to
+116
| selected_label_object = label_object.copy() | ||
| selected_label_object[selected_label_object != label] = 0 |
wli51
approved these changes
Apr 21, 2026
wli51
reviewed
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the texture module. Tests will fail due to not having the image loading functions present.
What kind of change(s) are included?
Checklist
Please ensure that all boxes are checked before indicating that this pull request is ready for review.