Skip to content

fix: anchor quit sheet slide animation#120

Merged
Wangnov merged 1 commit into
mainfrom
codex/fix-quit-sheet-slide
Jun 29, 2026
Merged

fix: anchor quit sheet slide animation#120
Wangnov merged 1 commit into
mainfrom
codex/fix-quit-sheet-slide

Conversation

@Wangnov

@Wangnov Wangnov commented Jun 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Wrap Sheet content in a bottom-anchored frame so the quit confirmation remains a real bottom sheet slide-up.
  • Use explicit sheet enter/exit keyframes and a bottom skirt to cover compositor gaps during the slide.
  • Align the global quit scrim with the window gutter variables.

Validation

  • npm run check
  • npm test -- Sheet
  • npm run tauri:build
  • codex review --base main: no findings

Note: codex review was run in a clean temporary worktree; its attempt to run vitest there failed because that worktree did not have node_modules, but the test passed in the main workspace.

@Wangnov Wangnov merged commit a3a3a10 into main Jun 29, 2026
5 checks passed
@Wangnov Wangnov deleted the codex/fix-quit-sheet-slide branch June 29, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant