Fix artist_alias FK violation and add import dedup#45
Merged
jakebromberg merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
added 2 commits
March 11, 2026 13:02
…event FK violations Artist alias and member CSVs from discogs-xml-converter contain all Discogs artists, but the artist table only has stub rows for filtered releases. This caused FK violations on artist_alias.artist_id during import. Now import_artist_details queries known artist IDs and filters artist_alias/artist_member rows during COPY. Also adds unique_key dedup configs for artist_alias, artist_member, and release_track to prevent duplicate row errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
artist_aliasandartist_memberimports to only known artist IDs, preventing FK violations when converter CSVs contain all Discogs artistsunique_keydedup configs forartist_alias,artist_member, andrelease_trackto prevent duplicate row errors during COPYid_filter/id_filter_columnmechanism toimport_csv()for column-based row filteringCloses #44
Test plan
unique_keyconfigs on artist_alias, artist_member, release_trackimport_artist_detailspassesartist_id_filter