fix: drop and recreate tables in schema to prevent stale data conflicts#37
Merged
jakebromberg merged 1 commit intomainfrom Mar 11, 2026
Merged
fix: drop and recreate tables in schema to prevent stale data conflicts#37jakebromberg merged 1 commit intomainfrom
jakebromberg merged 1 commit intomainfrom
Conversation
The schema used CREATE TABLE IF NOT EXISTS, which preserved data from previous pipeline runs. On re-runs, import_csv would hit UniqueViolation on release_pkey because old rows conflicted with new COPY data. The in-memory dedup only catches duplicates within the CSV, not against pre-existing table rows. Change to DROP TABLE IF EXISTS ... CASCADE followed by CREATE TABLE, ensuring a clean state for every fresh pipeline run. The --resume mode skips schema creation entirely, so in-progress work is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
Summary
create_database.sqlfromCREATE TABLE IF NOT EXISTStoDROP TABLE IF EXISTS ... CASCADE+CREATE TABLEUniqueViolationonrelease_pkeyduring re-imports--resumemode skips schema creation entirely, so in-progress work is unaffectedtest_schema_clears_stale_data_on_rerunthat inserts data, re-runs schema, and verifies tables are empty--cov-fail-under=80coverage enforcementTest plan