fix: dedup release IDs during CSV import#33
Merged
jakebromberg merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
The release table config lacked a unique_key, so duplicate release IDs in the CSV would cause a UniqueViolation on the release_pkey constraint during COPY. Add unique_key: ["id"] to skip duplicates (keeping the first occurrence), matching the pattern already used by release_artist, release_label, and release_track_artist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"unique_key": ["id"]to the release table config inimport_csv.py, matching the dedup pattern used byrelease_artist,release_label, andrelease_track_artistUniqueViolationonrelease_pkeyCloses #32
Cross-ref: WXYC/discogs-xml-converter#19 fixes the root cause in the converter.
Test plan
pytest tests/unit/test_import_csv.py— new testtest_release_table_has_unique_key_on_idand updatedtest_tables_with_unique_constraints_have_unique_keypytest -m postgres tests/integration/test_import.py::TestDuplicateReleaseIds— imports CSV with duplicate release IDs, verifies only first is kept