fix: rename album_title query param to album_name to match API spec#234
Open
jakebromberg wants to merge 1 commit intomainfrom
Open
fix: rename album_title query param to album_name to match API spec#234jakebromberg wants to merge 1 commit intomainfrom
jakebromberg wants to merge 1 commit intomainfrom
Conversation
The GET /library endpoint accepted album_title as a query parameter, but the OpenAPI spec (CatalogSearchParams) and the dj-site frontend both send album_name. This caused album searches to be silently ignored. Closes #233
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
album_titletoalbum_nameinAlbumQueryParamsforGET /libraryto matchCatalogSearchParamsinapi.yamland the dj-site frontendThe frontend sends
album_namebut the backend expectedalbum_title, so album searches were silently ignored — only artist name matching worked.Closes #233
Test plan
GET /library?album_name=Confieldreturns Autechre's "Confield"GET /library?artist_name=Built+to+Spill&album_name=Keep+itreturns matching resultsGET /librarywith no params still returns 400searches by album title,searches by both artist and album)