fix: change shift_covers.schedule_id from serial to integer#193
Merged
jakebromberg merged 2 commits intomainfrom Mar 10, 2026
Merged
fix: change shift_covers.schedule_id from serial to integer#193jakebromberg merged 2 commits intomainfrom
jakebromberg merged 2 commits intomainfrom
Conversation
jakebromberg
force-pushed
the
fix/18-schedule-id-type
branch
from
0d21961 to
4cf6824
Compare
9 tasks
AyBruno
approved these changes
Mar 9, 2026
FK columns should not auto-increment. Using serial meant inserts without explicit schedule_id would get sequence-generated values that may not reference valid schedule rows. Co-authored-by: Cursor <cursoragent@cursor.com>
AyBruno
force-pushed
the
fix/18-schedule-id-type
branch
from
4cf6824 to
ff832b3
Compare
Collaborator
|
Tests will pass once #195 is merged in and this is rebased onto main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Made with Cursor