fix: change flowsheet.play_order from serial to integer#192
Closed
jakebromberg wants to merge 4 commits intomainfrom
Closed
fix: change flowsheet.play_order from serial to integer#192jakebromberg wants to merge 4 commits intomainfrom
jakebromberg wants to merge 4 commits intomainfrom
Conversation
9 tasks
play_order is manually managed by reorder operations and should not auto-increment. The serial type wasted a sequence and could collide with manually assigned values. Co-authored-by: Cursor <cursoragent@cursor.com>
jakebromberg
force-pushed
the
fix/19-play-order-type
branch
from
220a205 to
8133555
Compare
added 3 commits
February 27, 2026 10:46
play_order changed from serial to integer, requiring explicit values. Add getNextPlayOrder() helper that computes max(play_order)+1 per show. Use it in addTrack, startShow, endShow, and DJ join/leave notifications.
getNextPlayOrder() was scoped per-show (WHERE show_id = X), making play_order values non-globally-unique. Queries use ORDER BY play_order DESC globally, so the sequence must be monotonically increasing across all shows to preserve correct ordering.
AyBruno
requested changes
Mar 9, 2026
| }; | ||
|
|
||
| export const addTrack = async (entry: NewFSEntry): Promise<FSEntry> => { | ||
| export const addTrack = async (entry: Omit<NewFSEntry, 'play_order'> & { play_order?: number }): Promise<FSEntry> => { |
Collaborator
There was a problem hiding this comment.
This is unnecessary. play_order is already of type number | undefined which is equivalent to what is being created here.
Collaborator
|
I'd like to discuss this one. I don't really see the need for it. Sequences are not an expensive or limited resource in our db so I don't see a "waste". It seems like we've re-implemented serial with extra network overhead here. |
Member
Author
|
Closing in favor of #199 (coordinated schema migration batch), which includes this change. You're right, the max()+1 approach re-implements serial with worse concurrency semantics. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flowsheet.play_ordercolumn type fromserialtointegerin the Drizzle schemaplay_orderis manually managed by reorder operations and should not auto-increment; the serial type wasted a PostgreSQL sequence and could collide with manually assigned valuestests/unit/database/schema.flowsheet.test.ts) that guards against regressionTest plan
serial('play_order')detected)integerwith a sequence that can be dropped separately)Fixes #19
Made with Cursor