fix: prevent SSH timeout stacking in MirrorSQL#189
Open
jakebromberg wants to merge 3 commits intomainfrom
Open
fix: prevent SSH timeout stacking in MirrorSQL#189jakebromberg wants to merge 3 commits intomainfrom
jakebromberg wants to merge 3 commits intomainfrom
Conversation
jakebromberg
force-pushed
the
fix/36-ssh-timeout-stacking
branch
from
9d80d0c to
3c6f4f4
Compare
AyBruno
requested changes
Mar 9, 2026
| export class MirrorSQL { | ||
| private static _instance: MirrorSQL | null = null; | ||
| private static _ssh: NodeSSH | null = null; | ||
| private static _timeoutHandle: ReturnType<typeof setTimeout> | null = null; |
Collaborator
There was a problem hiding this comment.
This file has been moved here and has similar changes: https://github.com/WXYC/Backend-Service/blob/main/shared/database/src/legacy/sql.mirror.ts
This PR should be converted to a cleanup to remove this file from living in the backend service.
Each sshInstance() call added a new 5-minute timeout without clearing the previous one, stacking dangling timeouts on rapid repeated calls. Co-authored-by: Cursor <cursoragent@cursor.com>
The MirrorSQL class moved from apps/backend/middleware/legacy/ to shared/database/src/legacy/. Updates the test import path and property names to match the current implementation.
jakebromberg
force-pushed
the
fix/36-ssh-timeout-stacking
branch
from
f2de0f4 to
b4ed7b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sshInstance()call inMirrorSQLcreated a new 5-minutesetTimeoutwithout clearing the previous one, causing dangling timeouts to stack on rapid repeated calls.clearTimeouton the existing handle before setting a new one.Test plan
tests/unit/middleware/legacy/ssh-timeout.test.ts— confirmsclearTimeoutis called on prior handles and that only the latest timeout firesdispose().npm run test:unit).Fixes #36
Made with Cursor