Skip to content

fix: standardize error response format to { message } across all endpoints #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jakebromberg wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: standardize error response format to { message } across all endpoints #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0437d83
fix: standardize error response format to { message } across all endp…
Feb 21, 2026
bb4fa96
fix: resolve lint errors
Feb 27, 2026
15c96a0
refactor: throw WxycError instead of inline error responses
Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 56 additions & 60 deletions apps/backend/controllers/djs.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { RequestHandler } from 'express';
import * as DJService from '../services/djs.service';
import { NewBinEntry } from '@wxyc/database';
import WxycError from '../utils/error.js';

export type binBody = {
dj_id: string;
Expand All @@ -11,22 +12,21 @@ export type binBody = {

export const addToBin: RequestHandler<object, unknown, binBody> = async (req, res, next) => {
if (req.body.album_id === undefined || req.body.dj_id === undefined) {
console.error('Bad Request, Missing Album Identifier: album_id');
res.status(400).send('Bad Request, Missing DJ or album identifier: album_id');
} else {
const bin_entry: NewBinEntry = {
dj_id: req.body.dj_id,
album_id: req.body.album_id,
track_title: req.body.track_title === undefined ? null : req.body.track_title,
};
try {
const added_bin_item = await DJService.addToBin(bin_entry);
res.status(200).json(added_bin_item);
} catch (e) {
console.error('Server error: Failed to insert into bin');
console.error(e);
next(e);
}
throw new WxycError('Bad Request, Missing DJ or album identifier: album_id', 400);
}

const bin_entry: NewBinEntry = {
dj_id: req.body.dj_id,
album_id: req.body.album_id,
track_title: req.body.track_title === undefined ? null : req.body.track_title,
};
try {
const added_bin_item = await DJService.addToBin(bin_entry);
res.status(200).json(added_bin_item);
} catch (e) {
console.error('Server error: Failed to insert into bin');
console.error(e);
next(e);
}
};

Expand All @@ -39,64 +39,60 @@ export type binQuery = {

export const deleteFromBin: RequestHandler<object, unknown, unknown, binQuery> = async (req, res, next) => {
if (req.query.album_id === undefined || req.query.dj_id === undefined) {
console.error('Bad Request, Missing Bin Entry Identifier: album_id or dj_id');
res.status(400).send('Bad Request, Missing Bin Entry Identifier: album_id or dj_id');
} else {
try {
//check that the dj_id === dj_id of bin entry
const removed_bin_item = await DJService.removeFromBin(parseInt(req.query.album_id), req.query.dj_id);
res.status(200).json(removed_bin_item);
} catch (e) {
console.error(e);
next(e);
}
throw new WxycError('Bad Request, Missing Bin Entry Identifier: album_id or dj_id', 400);
}

try {
//check that the dj_id === dj_id of bin entry
const removed_bin_item = await DJService.removeFromBin(parseInt(req.query.album_id), req.query.dj_id);
res.status(200).json(removed_bin_item);
} catch (e) {
console.error(e);
next(e);
}
};

export const getBin: RequestHandler<object, unknown, object, { dj_id: string }> = async (req, res, next) => {
if (req.query.dj_id === undefined) {
console.error('Bad Request, Missing DJ Identifier: dj_id');
res.status(400).send('Bad Request, Missing DJ Identifier: dj_id');
} else {
try {
const dj_bin = await DJService.getBinFromDB(req.query.dj_id);
res.status(200).json(dj_bin);
} catch (e) {
console.error("Error: Failed to retrieve dj's bin");
console.error(e);
next(e);
}
throw new WxycError('Bad Request, Missing DJ Identifier: dj_id', 400);
}

try {
const dj_bin = await DJService.getBinFromDB(req.query.dj_id);
res.status(200).json(dj_bin);
} catch (e) {
console.error("Error: Failed to retrieve dj's bin");
console.error(e);
next(e);
}
};

export const getPlaylistsForDJ: RequestHandler<object, unknown, object, { dj_id: string }> = async (req, res, next) => {
if (req.query.dj_id === undefined) {
console.error('Bad Request, Missing DJ Identifier: dj_id');
res.status(400).send('Bad Request, Missing DJ Identifier: dj_id');
} else {
try {
const playlists = await DJService.getPlaylistsForDJ(req.query.dj_id);
res.status(200).json(playlists);
} catch (e) {
console.error('Error: Failed to retrieve playlists');
console.error(e);
next(e);
}
throw new WxycError('Bad Request, Missing DJ Identifier: dj_id', 400);
}

try {
const playlists = await DJService.getPlaylistsForDJ(req.query.dj_id);
res.status(200).json(playlists);
} catch (e) {
console.error('Error: Failed to retrieve playlists');
console.error(e);
next(e);
}
};

export const getPlaylist: RequestHandler<object, unknown, object, { playlist_id: string }> = async (req, res, next) => {
if (req.query.playlist_id === undefined) {
console.error('Bad Request, Missing Playlist Identifier: playlist_id');
res.status(400).send('Bad Request, Missing Playlist Identifier: playlist_id');
} else {
try {
const playlist = await DJService.getPlaylist(parseInt(req.query.playlist_id));
res.status(200).json(playlist);
} catch (e) {
console.error('Error: Failed to retrieve playlist');
console.error(e);
next(e);
}
throw new WxycError('Bad Request, Missing Playlist Identifier: playlist_id', 400);
}

try {
const playlist = await DJService.getPlaylist(parseInt(req.query.playlist_id));
res.status(200).json(playlist);
} catch (e) {
console.error('Error: Failed to retrieve playlist');
console.error(e);
next(e);
}
};
Loading
Loading