fix: return 201 Created for all resource creation endpoints#182
Open
jakebromberg wants to merge 5 commits intomainfrom
Open
fix: return 201 Created for all resource creation endpoints#182jakebromberg wants to merge 5 commits intomainfrom
jakebromberg wants to merge 5 commits intomainfrom
Conversation
jakebromberg
force-pushed
the
fix/41-create-status-201
branch
from
899a692 to
46f729f
Compare
jakebromberg
force-pushed
the
fix/41-create-status-201
branch
from
09930c4 to
3fecec5
Compare
2 tasks
jakebromberg
force-pushed
the
fix/41-create-status-201
branch
from
3fecec5 to
1584aac
Compare
AyBruno
approved these changes
Mar 9, 2026
AyBruno
requested changes
Mar 9, 2026
Collaborator
AyBruno
left a comment
AyBruno
left a comment
There was a problem hiding this comment.
Need to address remaining .expect(200) in integration tests
All create endpoints (flowsheet entries, bin entries, albums, artists, rotation, formats, genres, schedule) returned 200 instead of 201. Co-authored-by: Cursor <cursoragent@cursor.com>
…ndpoints The addEntry controller now returns 201 Created instead of 200 OK. Update all POST /flowsheet assertions in the integration tests accordingly.
Updates remaining .expect(200) to .expect(201) in djs, library, and schedule integration tests for POST endpoints that create resources.
jakebromberg
force-pushed
the
fix/41-create-status-201
branch
from
1584aac to
ef5e804
Compare
All 19 POST /flowsheet calls in the metadata integration tests were still expecting 200, but the controller now returns 201 for successful creation. Updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addEntry(3 success paths) inflowsheet.controller.ts,addToBinindjs.controller.ts,addAlbum/addArtist/addRotation/addFormat/addGenreinlibrary.controller.ts, andaddToScheduleinschedule.controller.tsaddToBinandaddToScheduleto verify 201 statusTest plan
addToBinandaddToSchedulereturn 201Closes #41