Make Storage organ dynamics differentiable and efficient#83
Merged
Conversation
SarahAlidoost
approved these changes
Mar 2, 2026
Collaborator
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella thanks! 👍 looks good. Just small suggestions, then we can merge this.
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48
Notice that specific test data for the module do not exist in wofost72, so
test_storage_organ_dynamics.pyimplemented in this PR mainly checks the consistency of this new implementation (there are only a few assert_is_close statements) .However, the integration test
test_wofost_pp_with_storage_dynamicsconfirms that this new module numerically reproduces the correct results when used in combination with all the other wofost72's modules.