Conversation
|
@SCiarella Let's wait for #75, @fnattino is implementing nice changes there. Then we can integrate those into this and next modules. |
|
Let's also wait for #86 before integrating this |
| WSO = kk["WSO"] | ||
| # [!] DVS needs to be broadcasted explicetly because it is used | ||
| # in torch.where and the kiosk does not format it correctly | ||
| DVS = _broadcast_to(kk["DVS"], p.shape, self.dtype, self.device) |
There was a problem hiding this comment.
Good point. This is related to #22, accepting external dependencies through kiosk variable. Right now EngineTestHelper uses VariableKioskTestHelper from utils. For now, this solution is okay and we will fix this in another PR.
There was a problem hiding this comment.
@SCiarella @fnattino I added #22 as a task to the board, that one of us can work on it.
There was a problem hiding this comment.
Indeed, I think there is no way around here - we had to do the same in the partitioning module, where the same DVS variable has to be explicitely broadcasted to the parameters' shape.
|
@SarahAlidoost This PR is now ready for review. |
SarahAlidoost
left a comment
SarahAlidoost
left a comment
There was a problem hiding this comment.
@SCiarella Thanks, looks good 👍 , just a few comments/suggestions.
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
|
3 participants
Closes #43