Open
Conversation
We store these in teams for now. Butterfly UC is an exempion
…into feature/contrastive_setup
vdplasthijs
approved these changes
Mar 2, 2026
Collaborator
vdplasthijs
left a comment
vdplasthijs
left a comment
There was a problem hiding this comment.
Great! One very minor thing re double quotes in one of the configs. Can you check and fix/ignore if it doesn't matter and merge? Thanks!
| format: tif | ||
| use_target_data: true # default true | ||
| use_aux_data: false # default false | ||
| use_aux_data: none # default false |
Collaborator
There was a problem hiding this comment.
is it none or "none"? I see both (in this file and butterfly_coords.yml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change the auxilary handling from
{'aux': [num_values + tok_k_str_values]}to{'aux': tensor_num_values, 'top': [lst_top_k_str_values]This is in preparation for top-k validation and soft contrastive loss implementations.
Before submitting
pytestcommand?