Metrics configurable through yaml#50
Merged
vdplasthijs merged 11 commits intodevelopfrom Feb 26, 2026
Merged
Conversation
gabrieletijunaityte
added
the
duplicate
vdplasthijs
approved these changes
Feb 26, 2026
Collaborator
vdplasthijs
left a comment
vdplasthijs
left a comment
There was a problem hiding this comment.
Fantastic, really nice setup. Just have one very minor suggestion re including a check when computing cosine sim. What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #49 by introducing metrics wrapper class which intakes loss and metric class objects. This removes the need for separate need of UC/task-specific model classes.
Before submitting
pytestcommand?