Merged
Conversation
Closed
6 tasks
Collaborator
davidwalter2
left a comment
davidwalter2
left a comment
There was a problem hiding this comment.
Thanks this looks overall good but I strongly suggest to run one command per step which makes it easier to digest if something fails or to look up the logs
.github/workflows/main.yml
Outdated
| set -euo pipefail | ||
| mkdir -p $ALPHAS_OUTDIR | ||
|
|
||
| for fitvar in "ptll-yll" "ptll-yll-cosThetaStarll_quantile-phiStarll_quantile"; do |
Collaborator
There was a problem hiding this comment.
Apparently github actions have the matrix setting for these kind of things, on the top of the job do something like this and it will run in parallel (and it will also run the 4D fit in case the 2D fails or vice versa
strategy:
fail-fast: false
matrix:
include:
- mode: "2d"
fitvar: "ptll-yll"
fitdir_suffix: "ZMassDilepton_ptll_yll"
- mode: "4d"
fitvar: "ptll-yll-cosThetaStarll_quantile-phiStarll_quantile"
fitdir_suffix: "ZMassDilepton_ptll_yll_cosThetaStarll_quantile_phiStarll_quantile"
.github/workflows/main.yml
Outdated
| scripts/ci/run_with_singularity.sh scripts/ci/setup_and_run.sh rabbit_plot_pulls_and_impacts.py | ||
| "$ALPHAS_STABLE_FIT_LINK" --title CMS --subtitle Preliminary | ||
| --showNumbers --pullrange '2.1' --config wremnants/utilities/styles/styles.py --oneSidedImpacts --grouping min | ||
| -o "$WEB_DIR/$PLOT_DIR" --otherExtensions pdf png -n 50 --scaleImpacts 2.0 --postfix "$ALPHAS_IMPACTS_POSTFIX" |
Collaborator
There was a problem hiding this comment.
add "/alpha_s" to "-o" to move the 2d and 4d impacts also to the subdirectory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.