Skip to content

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Display notes in a dialog. Before, we were showing it in a mat-drawer on the right-side.
  • Clean up code
    • use dialog.open() directly instead of using observables to control opening behavior
    • pass in insertMode as Dialog param, to indicate if we are in editing mode, or inserting mode

Test

  • Notes appear in a dialog
  • Existing features of the notes work as before
    • Add/Edit/Delete notes
    • Insert note into report

…use dialog.open directly instead of using observables to control opening behavior
@hirokiterashima hirokiterashima self-assigned this Jan 16, 2026
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Jan 16, 2026
@qltysh
Copy link

qltysh bot commented Jan 16, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (5)

RatingFile% DiffUncovered Line #s
New file Coverage rating: F
src/app/notebook/notebook-notes/notebook-notes.component.ts14.3%47-55
New file Coverage rating: F
src/assets/wise5/vle/vle.component.ts0.0%71
New file Coverage rating: F
src/app/notebook/notebook-report/notebook-report.component.ts50.0%53
New file Coverage rating: A
src/app/notebook/notebook-launcher/notebook-launcher.component.ts100.0%
New file Coverage rating: F
src/assets/wise5/components/component-student.component.ts75.0%636
Total50.0%
🤖 Increase coverage with AI coding...

In the `show-notes-in-dialog` branch, add test coverage for this new code:

- `src/app/notebook/notebook-notes/notebook-notes.component.ts` -- Line 47-55
- `src/app/notebook/notebook-report/notebook-report.component.ts` -- Line 53
- `src/assets/wise5/components/component-student.component.ts` -- Line 636
- `src/assets/wise5/vle/vle.component.ts` -- Line 71

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review January 16, 2026 16:59
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I increased the width of the notes dialog and increased the number of notes per row on wider screens.

@hirokiterashima hirokiterashima merged commit 48b61cc into develop Jan 17, 2026
4 checks passed
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.202.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@hirokiterashima hirokiterashima deleted the show-notes-in-dialog branch January 17, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants