Add eslint and sort includes

.github/workflows/build.yml

@@ -14,7 +14,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16, 18, 20]
+        node-version: [20, 22, 24]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v3
@@ -28,7 +28,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16, 18, 20]
+        node-version: [20, 22, 24]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v3
@@ -38,13 +38,38 @@ jobs:
       - run: npm --prefix ./js/sign run build
       - run: npm --prefix ./js/sign test
 
-  prettier:
+  prettier-wbn:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: js/bundle
     steps:
-      - uses: actions/checkout@v2
-      - uses: creyD/prettier_action@v4.3
+      - uses: actions/checkout@v4
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+      - name: Install Prettier
+        run: |
+          npm install prettier@3.5 --no-save
+      - name: Run Prettier Check
+        run: |
+            npx prettier --check . --ignore-unknown
+
+  prettier-wbn-sign:
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: js/sign
+    steps:
+      - uses: actions/checkout@v4
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
         with:
-          prettier_options: --write **/*.{js,ts}
-          only_changed: True
-          dry: True
-          prettier_version: 2.7.1
+          node-version: 22
+      - name: Install Prettier and Plugins
+        run: |
+          npm install prettier@3.5 @ianvs/prettier-plugin-sort-imports --no-save
+      - name: Run Prettier Check
+        run: |
+            npx prettier --check . --ignore-unknown --plugin=@ianvs/prettier-plugin-sort-imports

.github/workflows/ghpages.yml

@@ -33,7 +33,7 @@ jobs:
         echo "::set-output name=path::$HOME/.cache/xml2rfc"
         date -u "+::set-output name=date::%FT%T"
     - name: "Cache References"
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         path: ${{ steps.cache-setup.outputs.path }}
         key: refcache-${{ steps.cache-setup.outputs.date }}
@@ -59,11 +59,11 @@ jobs:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
 
     - name: "Save HTML"
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         path: "*.html"
 
     - name: "Save Text"
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         path: "*.txt"

.github/workflows/publish.yml

@@ -24,7 +24,7 @@ jobs:
         echo "::set-output name=path::$HOME/.cache/xml2rfc"
         date -u "+::set-output name=date::%FT%T"
     - name: "Cache References"
-      uses: actions/cache@v2
+      uses: actions/cache@v4
       with:
         path: ${{ steps.cache-setup.outputs.path }}
         key: refcache-${{ steps.date.outputs.date }}

js/bundle/package.json

@@ -46,17 +46,18 @@
     "@types/node": "^12.7.11",
     "esbuild": "^0.25.0",
     "jasmine": "^4.2.1",
-    "prettier": "2.8.0",
+    "prettier": "3.5.3",
     "typescript": "^4.7.3"
   },
   "engines": {
-    "node": ">= 12.0.0"
+    "node": ">= 20.0.0"
   },
   "prettier": {
     "tabWidth": 2,
     "semi": true,
     "singleQuote": true,
     "printWidth": 80,
-    "proseWrap": "always"
+    "proseWrap": "always",
+    "trailingComma": "es5"
   }
 }

js/bundle/src/constants.ts

@@ -2,7 +2,7 @@ export const B1 = 'b1';
 export const B2 = 'b2';
 export const DEFAULT_VERSION = B2;
 export const APPROVED_VERSIONS = [B1, B2] as const;
-export type FormatVersion = typeof APPROVED_VERSIONS[number];
+export type FormatVersion = (typeof APPROVED_VERSIONS)[number];
 
 export function isApprovedVersion(param: any): param is FormatVersion {
   return APPROVED_VERSIONS.includes(param);

js/sign/.prettierignore

@@ -2,3 +2,4 @@ lib
 *.wbn
 *.swbn
 testdata
+README.md

js/sign/eslint.config.mjs

@@ -0,0 +1,31 @@
+// @ts-check
+
+import eslint from '@eslint/js';
+import { defineConfig } from 'eslint/config';
+import globals from 'globals';
+import tseslint from 'typescript-eslint';
+
+export default defineConfig(
+  {
+    ignores: ['lib/**', 'node_modules/**'],
+  },
+  eslint.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    files: ['**/*.ts', '**/*.js'],
+    languageOptions: {
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+  // Test specific rules/globals
+  {
+    files: ['**/tests/**/*.js', '**/*_test.js'],
+    languageOptions: {
+      globals: {
+        ...globals.jasmine,
+      },
+    },
+  }
+);