Skip to content

Queue a global task to resolve promises#106

Merged
reillyeon merged 2 commits intomainfrom
queue_resolve_task
Jan 8, 2025
Merged

Queue a global task to resolve promises#106
reillyeon merged 2 commits intomainfrom
queue_resolve_task

Conversation

@reillyeon
Copy link
Collaborator

@reillyeon reillyeon commented Jan 7, 2025

This change defines a task source for shape detection events, though the only instance where we have explicit method steps which actually resolve a promise is getSupportedFormats().

Fixed #105.


Preview | Diff

This change defines a task source for shape detection events, though the
only instance where we have explicit method steps which actually resolve
a promise is getSupportedFormats().

Fixed #105.
@reillyeon reillyeon requested a review from yell0wd0g January 7, 2025 22:14
Copy link
Collaborator

@yell0wd0g yell0wd0g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reillyeon reillyeon merged commit 7499404 into main Jan 8, 2025
1 check passed
@reillyeon reillyeon deleted the queue_resolve_task branch January 8, 2025 00:10
github-actions bot added a commit that referenced this pull request Jan 8, 2025
SHA: 7499404
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Jan 8, 2025
SHA: 7499404
Reason: push, by reillyeon

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shape-detection-api] Missing tasks in parallel steps in Accelerated Shape Detection in Images

2 participants