WIP: remove SC.LP; init when system is known; do not assemble u#107
Open
WIP: remove SC.LP; init when system is known; do not assemble u#107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have an inconsistency between the initialized system and the solved system: Restrictions are included after initialization of the linear solver...
This draft PR moves the
initialize_linear_solvercall into thesolve_linear_systemcall.It makes only sense to initialize after the restrictions are incorporated.
Also, is there a reason, why
SChas aLP? (linear problem?) This also duplicates ownership of the matrix and the right hand side. I just removed this property.Moreover, in the
solve_linear_systemcall, we construct alinsolve.uobject. This is already there and we break consistency with the initialized linear system. Thisuis constructed in theinitcall. So I removed it also.Test will probably fail :)