Skip to content

chore(l10n): New translations#802

Merged
SlayerOrnstein merged 48 commits into
masterfrom
l10n_master
May 17, 2026
Merged

chore(l10n): New translations#802
SlayerOrnstein merged 48 commits into
masterfrom
l10n_master

Conversation

@wfcd-bot-boi
Copy link
Copy Markdown
Collaborator

@wfcd-bot-boi wfcd-bot-boi commented May 15, 2026

Summary by CodeRabbit

  • New Features

    • Added a "Normal" fissures tab with localization across multiple languages.
  • Localization / Content Updates

    • Standardized/updated Baro notification wording.
    • Added Arcane/Inventoria UI strings: max/unranked titles, rank requirement text (with rank placeholder), category labels, total cost text (with cost placeholder), and an inventoria input error message.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 15, 2026

📝 Walkthrough

Walkthrough

Adds normalFissureTabTitle across multiple ARB files, updates baroNotificationDescription string values, and appends Arcane/Inventoria localization keys (with rank/cost placeholders and inventoriaInputError metadata) across the same language files.

Changes

Localization updates

Layer / File(s) Summary
Normal fissure tab title localization across language files
lib/l10n/arb/intl_cs.arb, lib/l10n/arb/intl_de.arb, lib/l10n/arb/intl_es.arb, lib/l10n/arb/intl_fr.arb, lib/l10n/arb/intl_it.arb, lib/l10n/arb/intl_ko.arb, lib/l10n/arb/intl_pl.arb, lib/l10n/arb/intl_pt.arb, lib/l10n/arb/intl_ru.arb, lib/l10n/arb/intl_sr.arb, lib/l10n/arb/intl_tr.arb, lib/l10n/arb/intl_zh.arb
Adds normalFissureTabTitle and @normalFissureTabTitle entries in each ARB file (lines ~173–177).
Update baroNotificationDescription values
lib/l10n/arb/intl_cs.arb, lib/l10n/arb/intl_de.arb, lib/l10n/arb/intl_es.arb, lib/l10n/arb/intl_fr.arb, lib/l10n/arb/intl_it.arb, lib/l10n/arb/intl_ko.arb, lib/l10n/arb/intl_pl.arb, lib/l10n/arb/intl_pt.arb, lib/l10n/arb/intl_ru.arb, lib/l10n/arb/intl_sr.arb, lib/l10n/arb/intl_tr.arb, lib/l10n/arb/intl_zh.arb
Replaces or corrects the baroNotificationDescription string values (single-line edits near line 248); metadata objects remain unchanged.
Add Arcane / inventoria localization keys and placeholders
lib/l10n/arb/intl_cs.arb, lib/l10n/arb/intl_de.arb, lib/l10n/arb/intl_es.arb, lib/l10n/arb/intl_fr.arb, lib/l10n/arb/intl_it.arb, lib/l10n/arb/intl_ko.arb, lib/l10n/arb/intl_pl.arb, lib/l10n/arb/intl_pt.arb, lib/l10n/arb/intl_ru.arb, lib/l10n/arb/intl_sr.arb, lib/l10n/arb/intl_tr.arb, lib/l10n/arb/intl_zh.arb
Appends maxRankTitle, requiresForNextArcaneRank ({rank}), unrankedTitle, rankCategoryTitle, acquisitionCategoryTitle, totalArcaneCost ({cost}), and inventoriaInputError with corresponding @... metadata (lines ~1406–1443).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • WFCD/navis#591: Modifies baroNotificationDescription in ARB localization files.

Suggested reviewers

  • SlayerOrnstein

Poem

I’m a rabbit of locales bright,
Hopping keys from left to right,
A Normal tab in every tongue,
Baro notes and arcane sung,
Translations set—now hop, delight! 🐇✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore(l10n): New translations' is vague and generic, providing no specific information about which translations were added or what features they support. Consider a more descriptive title that specifies the translations being added, such as 'chore(l10n): Add Arcane rank and Normal fissure translations' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch l10n_master

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/l10n/arb/intl_ru.arb`:
- Line 173: The value for the localization key "normalFissureTabTitle" is still
in English; replace the English string "Normal" with an appropriate Russian
translation (e.g., "Обычная") in the intl_ru.arb entry for
normalFissureTabTitle, and have the translation verified by a native Russian
speaker or localization specialist to ensure correct gender/case and context.

In `@lib/l10n/arb/intl_sr.arb`:
- Line 173: The string value for the localization key "normalFissureTabTitle" is
still in English ("Normal"); update the value to the Serbian translation for the
UI (replace "Normal" with the appropriate Serbian word or phrase for this tab
title) by editing the "normalFissureTabTitle" entry in the intl_sr.arb file;
ensure the new value is in correct Serbian orthography and quotation marks
remain valid JSON for the .arb file.

In `@lib/l10n/arb/intl_tr.arb`:
- Line 173: The ARB entry for the key "normalFissureTabTitle" uses the English
value "Normal" which must be translated into Turkish; update the value for the
"normalFissureTabTitle" key to the correct Turkish translation (e.g., "Normal"
if verified or an alternative approved by a Turkish reviewer) so the locale file
displays the localized label for Turkish users.

In `@lib/l10n/arb/intl_zh.arb`:
- Line 173: The localization key "normalFissureTabTitle" currently has the
English value "Normal"; update its value to a Traditional Chinese translation
(e.g., "正常") in intl_zh.arb so the UI displays the correct localized string for
this locale, and ensure the JSON string remains properly quoted and
comma-terminated like the surrounding entries.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f9053394-b9cf-4b87-9c15-42693604db48

📥 Commits

Reviewing files that changed from the base of the PR and between d3ff7bc and d25e8f6.

📒 Files selected for processing (11)
  • lib/l10n/arb/intl_cs.arb
  • lib/l10n/arb/intl_de.arb
  • lib/l10n/arb/intl_es.arb
  • lib/l10n/arb/intl_it.arb
  • lib/l10n/arb/intl_ko.arb
  • lib/l10n/arb/intl_pl.arb
  • lib/l10n/arb/intl_pt.arb
  • lib/l10n/arb/intl_ru.arb
  • lib/l10n/arb/intl_sr.arb
  • lib/l10n/arb/intl_tr.arb
  • lib/l10n/arb/intl_zh.arb

Comment thread lib/l10n/arb/intl_ru.arb
Comment thread lib/l10n/arb/intl_sr.arb
Comment thread lib/l10n/arb/intl_tr.arb
Comment thread lib/l10n/arb/intl_zh.arb
@SlayerOrnstein SlayerOrnstein enabled auto-merge (squash) May 17, 2026 15:12
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 12

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/l10n/arb/intl_cs.arb`:
- Around line 173-177: The Czech locale file contains English UI text entries
(e.g., the "normalFissureTabTitle" key and other entries around the sections
noted) — replace the English values with proper Czech translations while keeping
the metadata objects (like "`@normalFissureTabTitle`" description/type) unchanged;
locate each untranslated key in intl_cs.arb (the blocks around the reported
areas) and update the string values to Czech equivalents so the Czech ARB
contains only Czech UI text.

In `@lib/l10n/arb/intl_de.arb`:
- Around line 173-177: Several value entries in intl_de.arb are still in
English; update those values to German while preserving their metadata objects
(the "@..." entries). Locate the key "normalFissureTabTitle" and the other
entries in the same German ARB file that currently have English strings (the
block of keys flagged in the review) and replace their English values with
correct German translations, keeping the key names and description/type metadata
unchanged. Validate the ARB JSON remains well-formed after edits.

In `@lib/l10n/arb/intl_es.arb`:
- Around line 173-177: The Spanish locale file intl_es.arb contains untranslated
English values; update the specified keys (e.g., "normalFissureTabTitle") and
all other entries in the reported ranges (around lines 248 and 1407–1443) with
accurate Spanish translations, preserving the key names and JSON structure
(including each "@<key>" description and "type" objects) so only the string
values change and formatting remains valid.

In `@lib/l10n/arb/intl_fr.arb`:
- Around line 173-177: The French locale contains untranslated English values;
update the ARB entries so the keys with English text (e.g.,
"normalFissureTabTitle" and the other keys identified around the comment
ranges—the block starting ~line 248 and the block starting ~line 1407) have
proper French translations and update their corresponding metadata if needed;
locate these keys in intl_fr.arb (search for "normalFissureTabTitle" and the
English strings present in the later block) and replace the English values with
accurate French strings while preserving the key names and JSON structure.

In `@lib/l10n/arb/intl_it.arb`:
- Around line 173-177: Several entries in the Italian ARB file are still in
English; locate the translation keys at/around "normalFissureTabTitle" and the
other keys flagged around lines 173, 248 and 1407–1443 and replace their English
values with correct Italian translations while leaving the metadata objects
(e.g., "`@normalFissureTabTitle`") unchanged; ensure you update the string values
for each key (for example "normalFissureTabTitle" -> "Normale") and verify there
are no remaining English strings in intl_it.arb.

In `@lib/l10n/arb/intl_ko.arb`:
- Around line 173-177: Several English strings were left in the Korean resource
file; update the untranslated keys in intl_ko.arb by providing Korean
translations for the affected message IDs (e.g., "normalFissureTabTitle" and the
other keys starting around the block that contains the similar tab/section
labels and the later group beginning at the long list of entries after message
id "..." ), replacing the English values with proper Korean text while keeping
the JSON/ARB structure and preserving the metadata objects (the "@<key>"
description/type entries) for each key; ensure all occurrences of those English
phrases are translated consistently across the keys referenced in the diff.

In `@lib/l10n/arb/intl_pl.arb`:
- Around line 173-177: Several UI strings in the Polish ARB are still in
English; update the untranslated keys (e.g., "normalFissureTabTitle" and the
other English entries referenced around lines 248 and 1407-1443) by replacing
the English text with proper Polish translations for each message key and ensure
any corresponding metadata (the "`@key`" descriptions) remain accurate; locate the
keys in lib/l10n/arb/intl_pl.arb (search for the exact keys like
"normalFissureTabTitle" and the other untranslated keys) and provide Polish
translations for their values so the file contains only Polish UI strings.

In `@lib/l10n/arb/intl_pt.arb`:
- Line 248: The Portuguese ARB contains untranslated English strings (e.g.,
"baroNotificationDescription") which breaks the locale; update every English
value in intl_pt.arb to fluent Portuguese equivalents, preserving the original
message intent, punctuation, interpolation/placeholders and any ICU/plural
syntax, and apply the same change for the other untranslated keys referenced
(lines ~1407-1443) so all values in intl_pt.arb are proper Portuguese
translations.

In `@lib/l10n/arb/intl_ru.arb`:
- Line 248: The Russian locale file still contains untranslated English entries;
update the resource key "baroNotificationDescription" (and all entries between
the block covering lines shown, i.e., the keys present in the 1407-1443 range)
with proper Russian translations so the UI displays fully localized text; locate
the keys by name in intl_ru.arb, replace the English values with their Russian
equivalents, and run any locale validation/linting to ensure the .arb remains
valid JSON and all translated strings are present.

In `@lib/l10n/arb/intl_sr.arb`:
- Line 248: The Serbian ARB file contains English text for the key
"baroNotificationDescription" (value "Notifications for both Baro's arrival and
departure.") and additional English entries later; replace that value with the
correct Serbian translation and scan the same intl_sr.arb file for any other
English strings (the block noted in the review) and provide Serbian translations
for each corresponding message key so all message values are localized
consistently.

In `@lib/l10n/arb/intl_tr.arb`:
- Line 248: The Turkish ARB contains untranslated English entries—specifically
the key "baroNotificationDescription" and the recently added English strings in
the same Turkish locale file (intl_tr.arb); translate those values into proper
Turkish, preserving any placeholders/ICU syntax and punctuation exactly as in
the original keys, update the corresponding string values in intl_tr.arb, and
run the localization/lint check to ensure no formatting or placeholder
regressions.

In `@lib/l10n/arb/intl_zh.arb`:
- Line 248: The intl_zh.arb locale contains English entries that must be
translated to Traditional Chinese: update the keys such as
"baroNotificationDescription" (and all message keys in the block currently
between the other entries around lines 1407-1443) with proper Traditional
Chinese translations, preserving the exact JSON key names and message
placeholders/ICU syntax, keep the file valid JSON/ARB formatting (quotes,
commas, escapes) and run your localization lint/CI to ensure no missing or
malformed entries remain.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 02b301e9-5770-45b2-b694-5be7bebadf8a

📥 Commits

Reviewing files that changed from the base of the PR and between d25e8f6 and 79661e7.

📒 Files selected for processing (12)
  • lib/l10n/arb/intl_cs.arb
  • lib/l10n/arb/intl_de.arb
  • lib/l10n/arb/intl_es.arb
  • lib/l10n/arb/intl_fr.arb
  • lib/l10n/arb/intl_it.arb
  • lib/l10n/arb/intl_ko.arb
  • lib/l10n/arb/intl_pl.arb
  • lib/l10n/arb/intl_pt.arb
  • lib/l10n/arb/intl_ru.arb
  • lib/l10n/arb/intl_sr.arb
  • lib/l10n/arb/intl_tr.arb
  • lib/l10n/arb/intl_zh.arb

Comment thread lib/l10n/arb/intl_cs.arb
Comment thread lib/l10n/arb/intl_de.arb
Comment thread lib/l10n/arb/intl_es.arb
Comment thread lib/l10n/arb/intl_fr.arb
Comment thread lib/l10n/arb/intl_it.arb
Comment thread lib/l10n/arb/intl_pt.arb
Comment thread lib/l10n/arb/intl_ru.arb
Comment thread lib/l10n/arb/intl_sr.arb
Comment thread lib/l10n/arb/intl_tr.arb
Comment thread lib/l10n/arb/intl_zh.arb
@SlayerOrnstein
Copy link
Copy Markdown
Member

@coderabbitai resolve

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 17, 2026

✅ Actions performed

Comments resolved. Approval is disabled; enable reviews.request_changes_workflow to allow explicit top-level @coderabbitai resolve or @coderabbitai approve commands.

@SlayerOrnstein SlayerOrnstein disabled auto-merge May 17, 2026 15:24
@SlayerOrnstein SlayerOrnstein enabled auto-merge (squash) May 17, 2026 15:25
@SlayerOrnstein SlayerOrnstein changed the title fix(l10n): New translations chore(l10n): New translations May 17, 2026
@SlayerOrnstein SlayerOrnstein disabled auto-merge May 17, 2026 15:25
@SlayerOrnstein SlayerOrnstein enabled auto-merge (squash) May 17, 2026 15:25
@SlayerOrnstein SlayerOrnstein disabled auto-merge May 17, 2026 15:26
@SlayerOrnstein SlayerOrnstein merged commit 1f0b303 into master May 17, 2026
4 checks passed
@SlayerOrnstein SlayerOrnstein deleted the l10n_master branch May 17, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants