Skip to content

Conversation

@jangevaare
Copy link
Member

@jangevaare jangevaare commented Jan 20, 2026

This pull request incorporates quick fixes from running the latest version of ty against the codebase for typing issues.

  • Removed unnecessary type: ignore comments in loops over clients and DataFrame rows, improving type safety in build_client_lookup and build_preprocess_result (pipeline/bundle_pdfs.py, pipeline/preprocess.py). [1] [2]
  • Added @overload type annotations and improved type handling for the filter_columns utility, allowing it to handle both None and pd.DataFrame inputs more robustly (pipeline/preprocess.py).
  • Added missing imports (e.g., overload from typing) and made minor code style improvements, such as whitespace and line breaks, for better readability (pipeline/preprocess.py). [1] [2] [3] [4] [5]
  • Updated unit tests to use pd.Index for DataFrame columns and improved test assertions for clarity and correctness (tests/unit/test_preprocess.py). [1] [2]

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pipeline/preprocess.py 85.71% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@TiaTuinstra TiaTuinstra merged commit f4ab939 into main Jan 21, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants