feat: added Korea strategy for p2_lr, p3_ur, p3_apoc, p4_dd, p4_ct#37
Open
feat: added Korea strategy for p2_lr, p3_ur, p3_apoc, p4_dd, p4_ct#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I'm a FFXIV player from Korea, and I've landed upon this great project.
However, it didn't align with the strategies used in Korea, so I have included them.
Issues
p4_ct linescanner
I have read about using the linescanner instead of just using x and y coords,
but due to the position of the tankers and the party by the Korea strategy,
the linescanner from west/east picks up someone else since the party is closer to the scanner than the tanks.
So I just used the x and y coords for checking.
p4_ct Arm's length
Korea's strategy uses Arm's length, but I am new to Godot Engine
and failed to connect it to the function in the player control section.
So I just hacked the function and copied it over to the p4 sequence file.