Skip to content

wrong pip command in Containerfile#547

Merged
ramseymcgrath merged 1 commit intomainfrom
container-imports2
Jan 20, 2026
Merged

wrong pip command in Containerfile#547
ramseymcgrath merged 1 commit intomainfrom
container-imports2

Conversation

@ramseymcgrath
Copy link
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings January 20, 2026 00:59
@ramseymcgrath ramseymcgrath merged commit bd794f6 into main Jan 20, 2026
11 of 24 checks passed
@ramseymcgrath ramseymcgrath deleted the container-imports2 branch January 20, 2026 00:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an incorrect pip install command in the Containerfile that had a logic error due to operator precedence. The original command attempted an editable install with a fallback to regular install, but the use of || and && operators caused both installs to run regardless of the first command's success. The fix simplifies to a single regular install, which is the correct approach for containers where source code is copied rather than mounted.

Changes:

  • Replaced buggy pip install command with a single, correct regular install command
  • Added explanatory comment about why regular install (not editable) is used in containers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

E2E Integration Test Summary

Workflow Run: 820
Commit: 006e1e7
Branch: 547/merge
Triggered by: pull_request
Timestamp: Tue Jan 20 01:01:45 UTC 2026

Test Results

End-to-End Tests

E2E Tests: FAILED
⏸️ Security Scan: SKIPPED
⏸️ Performance Analysis: SKIPPED

Artifacts

  • Test reports and logs available in workflow artifacts
  • Artifacts retained for 7-30 days depending on type

@codecov
Copy link

codecov bot commented Jan 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant