feat: upgrade OpenCV to 4.12.0 static and cache builds #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… on all platforms
- Fix FetchContent timestamp policy (CMP0135) in CMakeLists.txt - Implement robust rate-limiting tests in test_auth_logic.cpp - Modernize C++ usage (headers, casts, const) across PAM and service - Extract IPC protocol to src/common/ - Deep clean of build configuration
- **Build**: Disabled excessive GTest installation in CMake to resolve package conflicts. - **Tests**: Increased lockout duration in test_auth_logic.cpp to prevent flakiness on slower emulated architectures. - **Docker**: Fixed FetchContent SSL errors (added ca-certificates) and ensure models are correctly installed before running tests. - **Cleanup**: Updated .gitignore to exclude log files.
…dels - **CI**: Added step to , , and jobs to ensure tests running on host can find models in . - **CI**: Added missing step to . - **Models**: Updated and to fetch models from Hugging Face (OpenCV Zoo mirror). - **Models**: Updated YuNet model to .
…face detection, and include Git hash or build date in the version string.
- Promoted isValidUsername to public utility in utils.hpp - Removed unused headers (numeric, string_view) - Fixed CMake CMP0135 warning for googletest - Resolved test linking errors
- Updated Dockerfiles to install models to /usr/share/linuxcampam/models - Updated .dockerignore to exclude opencv_static and build artifacts to prevent cross-arch contamination
Vladush
force-pushed
the
feature/opencv-upgrade-static
branch
from
5e9fa36 to
0891b24
Compare
This package is not available in debian:sid for riscv64 and caused build failures.
…ve OpenCV build script flexibility, and optimize embedding listing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I upgraded the OpenCV dependency to version 4.12.0, switched to a static build strategy, and implemented comprehensive documentation and CI improvements. This PR consolidates several refactors including version bumping, documentation auditing, and bug fixes for video call compatibility.
Key Changes
opencv_static(binary) andopencv_build(source) directories from the repository history to significantly reduce repository size and resolve linting issues.CHANGELOG.mdwith release notes.README.md,CONTRIBUTING.md,docs/CONFIGURATION.md, anddocs/SECURITY_ASSESSMENT.mdfor clarity and consistency.show-config)..github/workflows/ci.ymlto build OpenCV from source and cache the artifacts preventing binary tracking.markdownlintfailures by correcting blockquote syntax.build-clangfailures by adding missing dependencies (libpam0g-dev,libgtest-dev) and configuringCC/CXXenvironment variables./etcto/usr/share) to match test expectations.CMakeLists.txtto prioritize the locally built static OpenCV.Compatibility Note
face_recognition_sface_2021dec.onnx) remains unchanged from the previous version. Existing user embeddings are fully compatible and no migration is required.Type of change
How Has This Been Tested?
build-opencvscript runs, caches correctly, and that linting passes (after history rewrite).build-gccandbuild-aarch64after fixing model paths.cmakeconditional logic for finding OpenCV.Checklist