Skip to content

【WIP】fix: fix issue with multiline text render pos #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neuqzxy wants to merge 1 commit into
base: dev/0.19.0
Choose a base branch
from
Open

【WIP】fix: fix issue with multiline text render pos #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/changes/@visactor/vrender-core/fix-multiline-text-bounds_2024-04-02-08-52.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"changes": [
{
"packageName": "@visactor/vrender-core",
"comment": "fix: fix issue with multiline text render pos",
"type": "none"
}
],
"packageName": "@visactor/vrender-core"
}
3 changes: 2 additions & 1 deletion packages/vrender-core/src/core/contributions/textMeasure/layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,8 @@ export class CanvasTextLayout {
}

// line.topOffset = lineHeight * 0.79 + origin[1]; // 渲染默认使用alphabetic
line.topOffset = (lineHeight - this.textOptions.fontSize) / 2 + this.textOptions.fontSize * 0.79 + origin[1];
// 0.79在中文会超出，使用0.82
line.topOffset = (lineHeight - this.textOptions.fontSize) / 2 + this.textOptions.fontSize * 0.82 + origin[1];
origin[1] += lineHeight;

return line;
Expand Down
18 changes: 18 additions & 0 deletions packages/vrender/__tests__/browser/src/pages/text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,24 @@ export const page = () => {
});
graphics.push(circle);

const wt = createText({
text: ['省/自治区字段信息jfkdlafjkdag'],
ellipsis: '...',
fill: 'red',
fontSize: 68,
fontWeight: 'bold',
textAlign: 'center',
textBaseline: 'top',
width: 1628,
maxLineWidth: 1628,
x: 814,
y: 100,
_debug_bounds: true,
wrap: true
});
graphics.push(wt);
console.log('wt', wt);

const rect = createRect({
x: t.AABBBounds.x1,
y: t.AABBBounds.y1,
Expand Down