remove ordering from count query#43
Open
mfedortsov wants to merge 12 commits intoVirtusLab:masterfrom
Open
Conversation
Support up to 22 columns
Bump coverageMInimum to 65%
Update build.sbt
…filtering Add disjunction filtering based on enum and int values VirtusLab#17
Member
|
What is motivation for this change? Is there any perfmance gain? |
Author
|
I found interesting query from our servers. Yes, it will improve performance for some queries, especially if query contains several left joins inside. |
Member
|
LGTM! The idea to not sort data when we only need a count of the items seems to be a reasonable approach. |
Member
|
@mfedortsov Could you make a PR against the branch 1.1.x (with slick 3.0.3) also? (I will merge the 1.1.x branch into the master soon). |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split query by 2 part: